[HttpFoundation] deprecate finding deep items in request parameters #16007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03ff6cb to
be11681
Compare
| @@ -88,6 +90,10 @@ public function add(array $parameters = array()) | |||
| */ | |||
| public function get($path, $default = null, $deep = false) | |||
There was a problem hiding this comment.
IMO $path should be renamed to $key. It's not a path anymore when deep cannot/should not be used, esp. in 3.0 then.
|
test failures are not related |
| self::$propertyAccessor = PropertyAccess::createPropertyAccessor(); | ||
| } | ||
|
|
||
| return self::$propertyAccessor->getValue($value, substr($path, $pos)); |
There was a problem hiding this comment.
This will create exceptions if there is no value for the path. But it should instead return the default as previously in the deep logic. So you need to catch them.
be11681 to
2784cf4
Compare
| try { | ||
| return self::$propertyAccessor->getValue($value, substr($path, $pos)); | ||
| } catch (AccessException $e) { | ||
| return null; |
There was a problem hiding this comment.
Being able to pass a default value is useless as the code is only used internally by the Security HTTP component which does not have different default values. I removed this argument entirely.
2784cf4 to
845d573
Compare
| $root = substr($path, 0, $pos); | ||
|
|
||
| if (null === $value = $parameters->get($root)) { | ||
| return null; |
There was a problem hiding this comment.
return; is what we use in Symfony (same below).
|
👍 |
845d573 to
47fba88
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2015
…st parameters (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] deprecate finding deep items in request parameters | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is the same as #14203 but using the PropertyAccess component in the Security HTTP component to query nested request parameters and is rebased on the `2.8` branch. Commits ------- 47fba88 deprecate finding deep items in request parameters
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Sep 30, 2015
Since symfony#16007, the Security HTTP component requires the PropertyAccess component to access nested parameter bag values. Since the Security component replaces the Security HTTP component, all dependencies of the replaced packages must be mirrored here.
fabpot
added a commit
that referenced
this pull request
Sep 30, 2015
…xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [Security] add dependency required by a replaced package | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Since #16007, the Security HTTP component requires the PropertyAccess component to access nested parameter bag values. Since the Security component replaces the Security HTTP component, all dependencies of the replaced packages must be mirrored here. Commits ------- d7034db add dependency required by a replaced package
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #14203 but using the PropertyAccess component in the Security HTTP component to query nested request parameters and is rebased on the
2.8branch.