[FrameworkBundle] Tag deprecated services #16011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,7 @@ | |||
| <services> | |||
| <service id="form.csrf_provider" class="Symfony\Component\Form\Extension\Csrf\CsrfProvider\CsrfTokenManagerAdapter"> | |||
| <argument type="service" id="security.csrf.token_manager" /> | |||
| <deprecated>The "%service_id%" service is deprecated since Symfony 2.8 and will be removed in 3.0. Use the "security.csrf.token_manager" service instead.</deprecated> | |||
There was a problem hiding this comment.
it is deprecated since older versions than 2.8 actually
6e97c12 to
882265e
Compare
| --> | ||
| <service id="request" scope="request" synthetic="true" synchronized="true" /> | ||
| <service id="request" scope="request" synthetic="true" synchronized="true"> | ||
| <deprecated>The "%service_id%" service is deprecated since Symfony 2.8 and will be removed in 3.0. Use the "request_stack" service instead.</deprecated> |
There was a problem hiding this comment.
fixed (and the other comments also)
882265e to
87e8e8f
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2015
…kas) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] Tag deprecated services | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Tag deprecated services as such. Some are deprecated by transitivity with their class definition. Having given some workshops on migrating to sf 3.0, the deprecation triggered at the class level is cryptic to most. Triggering a more tailored one about the service is really important to me in order to help users migrate. Commits ------- 87e8e8f [FrameworkBundle] Tag deprecated services
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag deprecated services as such. Some are deprecated by transitivity with their class definition.
Having given some workshops on migrating to sf 3.0, the deprecation triggered at the class level is cryptic to most. Triggering a more tailored one about the service is really important to me in order to help users migrate.