Minor fixes for the profiler and toolbar #16023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@javiereguiluz Swiftmailer sets the tag in the extension: https://github.com/symfony/swiftmailer-bundle/blob/master/DependencyInjection/SwiftmailerExtension.php#L60 |
|
@wouterj thanks! |
This was referenced Sep 30, 2015
stof
added a commit
to doctrine/DoctrineBundle
that referenced
this pull request
Sep 30, 2015
This PR was merged into the 1.6.x-dev branch. Discussion ---------- Tweaked collector priority In symfony/symfony#16023 we're tweaking the priorities of the toolbar/profiler panels. The `265` value is the right number for Doctrine ... but maybe you don't want to merge it yet because this will change a lot the position of the Doctrine panel in the profiler/toolbar of Symfony versions older than 2.8. Commits ------- 0606b7d Changed the priority to make it compatible with older Symfony versions bdcac12 Fixed the priority number 41a7148 Tweaked the Doctrine priority
stof
added a commit
to symfony/swiftmailer-bundle
that referenced
this pull request
Sep 30, 2015
This PR was squashed before being merged into the 2.3-dev branch (closes #116). Discussion ---------- Tweaked the collector priority In symfony/symfony#16023 we're tweaking the priorities of the toolbar/profiler panels. The 260 value is the right number for SwiftMailer ... but maybe you don't want to merge it yet because this will change a lot the position of the SwiftMailer panel in the profiler/toolbar of Symfony versions older than 2.8. Commits ------- 0e85658 Tweaked the collector priority
|
Thank you @javiereguiluz. |
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…iluz) This PR was squashed before being merged into the 2.8 branch (closes symfony#16023). Discussion ---------- Minor fixes for the profiler and toolbar | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | partially symfony#15439 | License | MIT | Doc PR | - Changes: * Fixed a misaligned icon * Changed the priorities of the collectors to better control their position and to leave a "gap" between priorities so custom panels can be displayed between the default panels. This idea came from @stof. By the way, @stof do you know how can I set the priority of the SwiftMailer collector? Its definition is the only one that doesn't use the `<tag name="data_collector" />`: ```xml <service id="swiftmailer.data_collector" class="%swiftmailer.data_collector.class%"> <argument type="service" id="service_container" /> </service> ``` https://github.com/symfony/swiftmailer-bundle/blob/master/Resources/config/swiftmailer.xml#L90-L92 Commits ------- bff4098 Minor fixes for the profiler and toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
By the way, @stof do you know how can I set the priority of the SwiftMailer collector? Its definition is the only one that doesn't use the
<tag name="data_collector" />:https://github.com/symfony/swiftmailer-bundle/blob/master/Resources/config/swiftmailer.xml#L90-L92