[DomCrawler] always pass base href to subcrawlers #16028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that all relevant information is passed to created crawlers. To avoid future regressions, this commit backports the approach taken by @stof in symfony#15934 to have a single place in the class that is responsible to create subcrawler instances.
c615560 to
3d9a748
Compare
| @@ -370,7 +370,7 @@ public function each(\Closure $closure) | |||
| */ | |||
| public function slice($offset = 0, $length = -1) | |||
| { | |||
| return new static(iterator_to_array(new \LimitIterator($this, $offset, $length)), $this->uri); | |||
There was a problem hiding this comment.
for reference, this is the place where the baseHref was missing.
There was a problem hiding this comment.
Yes, in #15934 I asked to backport this to the 2.3 branch, but realised that the slice() method was introduced later. That's why I did not backport your changes to Symfony 2.3.
|
I'm 👍 on backporting this |
|
👍 Status: Reviewed |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 1, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [DomCrawler] always pass base href to subcrawlers | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Make sure that all relevant information is passed to created crawlers. To avoid future regressions, this commit backports the approach taken by @stof in #15934 to have a single place in the class that is responsible to create subcrawler instances. Commits ------- 3d9a748 [DomCrawler] always pass base href to subcrawlers
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that all relevant information is passed to created crawlers.
To avoid future regressions, this commit backports the approach taken by
@stof in #15934 to have a single place in the class that is responsible
to create subcrawler instances.