[WIP][3.0][Form] Removed usage of deprecated form tag attributes #16046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5302e68 to
d86fb3f
Compare
|
@fabpot 2.8 needs to be merged into master first. Are you on it? |
|
@Tobion No, I'm in a meeting right now, can you do it? |
|
@fabpot merged |
d86fb3f to
215fdbe
Compare
|
Rebased & included renaming alias -> extended_type |
| } else { | ||
| @trigger_error('The extended_type option of the form.type_extension tag is required since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED); | ||
| $extendedType = $serviceId; | ||
| throw new \InvalidArgumentException(sprintf('Tagged form type extension must have the extended type configured using the extended_type/extended-type attribute, none was configured for the "%s" service.', $serviceId)); |
There was a problem hiding this comment.
"Tagged form type extensionS" as this is valid for every type extension
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Oct 1, 2015
…ibutes (WouterJ) This PR was merged into the 3.0-dev branch. Discussion ---------- [WIP][3.0][Form] Removed usage of deprecated form tag attributes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - WIP because it needs some adjustments after #15926 is merged Commits ------- 215fdbe Removed alias attribute usages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because it needs some adjustments after #15926 is merged