[CssSelector] synchronize tests for static and non-static API #16052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->fail('->parse() throws an Exception if the css selector is not valid'); | ||
| } catch (\Exception $e) { | ||
| $this->assertInstanceOf('\Symfony\Component\CssSelector\Exception\ParseException', $e, '->parse() throws an Exception if the css selector is not valid'); | ||
| $this->assertEquals('Expected identifier, but <eof at 3> found.', $e->getMessage(), '->parse() throws an Exception if the css selector is not valid'); |
There was a problem hiding this comment.
This should be turned into a @expectedException IMO (and a @expectedExceptionMessage instead of catching all exceptions (including from ->fail()) and then asserting
There was a problem hiding this comment.
Usually I would agree. Though do you know why it was done this way originally?
There was a problem hiding this comment.
probably legacy from early attempts at using PHPUnit
Synchronizing the classes ensures that no tests are lost when the legacy API is removed in symfony#16020 for Symfony 3.0, thus mitigating the risk of future regressions.
2559ba7 to
2b29a40
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 1, 2015
…c API (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [CssSelector] synchronize tests for static and non-static API | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Synchronizing the classes ensures that no tests are lost when the legacy API is removed in #16020 for Symfony 3.0, thus mitigating the risk of future regressions. Commits ------- 2b29a40 synchronize tests for static and non-static API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronizing the classes ensures that no tests are lost when the legacy
API is removed in #16020 for Symfony 3.0, thus mitigating the risk of
future regressions.