Simplify AbstractVoter #16079
Closed
Simplify AbstractVoter #16079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this must be done in However, I agree that passing the object rather than the class name makes it much easier to handle inheritance, as it will just be a |
|
👍 for doing this in 2.8 |
| @@ -758,6 +758,38 @@ UPGRADE FROM 2.x to 3.0 | |||
| * The `supportsAttribute()` and `supportsClass()` methods of classes `AuthenticatedVoter`, `ExpressionVoter` | |||
| and `RoleVoter` have been removed. | |||
|
|
|||
| * The `AbstractVoter::supports()` method signature have changed: second argument now is object instead of class name. | |||
There was a problem hiding this comment.
Minor grammar thing:
The AbstractVoter::supports() method signature has changed: second argument is now an object instead of class name.
|
will do it tomorrow. Thanx @jenkoian for corrections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can make one more small change if we are breaking compatibility of
AbstractVoterclass anyway.