Pass missing request template variables #16104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +96,7 @@ public function panelAction(Request $request, $token) | |||
| } | |||
|
|
|||
| if (!$profile = $this->profiler->loadProfile($token)) { | |||
| return new Response($this->twig->render('@WebProfiler/Profiler/info.html.twig', array('about' => 'no_token', 'token' => $token)), 200, array('Content-Type' => 'text/html')); | |||
| return new Response($this->twig->render('@WebProfiler/Profiler/info.html.twig', array('about' => 'no_token', 'token' => $token, 'request' => $request)), 200, array('Content-Type' => 'text/html')); | |||
There was a problem hiding this comment.
Shouldn't we change this to a redirect to _profiler_info, just like is done with the other info messages?
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2015
This PR was merged into the 2.8 branch. Discussion ---------- Pass missing request template variables Some render calls were missing the `request` variable, while it is used in the `layout.html.twig` template. | Q | A | --- | --- | Fixed tickets | - | License | MIT Commits ------- 7f1b2c2 Pass missing request template variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some render calls were missing the
requestvariable, while it is used in thelayout.html.twigtemplate.