[HttpFoundation] fixed bag registration after session start #16136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function testRegisterBagAfterStarting() | ||
| { | ||
| $storage = $this->getStorage(); | ||
| $storage->start(); |
There was a problem hiding this comment.
Can you also add a test to see what happens when you register before starting?
There was a problem hiding this comment.
Yes, see above. Did you expect it this way?
| * @param SessionBagInterface $bag | ||
| * @param array|null $session | ||
| */ | ||
| protected function loadSessionBag(SessionBagInterface $bag, array &$session = null) |
|
Closing as the "right" fix would instead be to throw an exception when trying to register a bag after the session is started. |
fabpot
added a commit
that referenced
this pull request
Mar 8, 2016
…ed sessions (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] exception when registering bags for started sessions | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10707, #16136 | License | MIT | Doc PR | Commits ------- c4a5b67 exception when registering bags for started sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggested this fix some time ago, but there were no resoponses. Hopefully, this PR finds some attention 😃