[Console] Fix bug with format, when set max count, by start method in progress bar #16149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test to avoid regressions in the future? |
|
Done |
|
LGTM. I've created #16196 where I've added another commit to fix the case where |
fabpot
added a commit
that referenced
this pull request
Oct 11, 2015
…tart() and some other edge cases (vsychov, fabpot) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix progress bar formatting when max is set on start() and some other edge cases | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Besides what #16149 fixed, it also fixes the case where `setFormat()` is called before `start()`. From #16149 When I set max count, by call "ProgressBar::start()", I got invalid progress bar format. Example code: ```php $bar = new ProgressBar($output, 100); $bar->start(); $bar->advance(100); $bar->finish(); ``` Output: 100/100 [============================] 100% Example code: ```php $bar = new ProgressBar($output); $bar->start(100); $bar->advance(100); $bar->finish(); ``` Output: 100 [============================] Commits ------- e651da4 [Console] fixed progress bar format on edge cases 3cbfa63 fix bug with set max count, by start method in progress bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I set max count, by call "ProgressBar::start()", I got invalid progress bar format.
Example code:
Output:
100/100 [============================] 100%
Example code:
Output:
100 [============================]