Added more tests for PropertyAccess #16155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $object->firstName = array('Bernhard'); | ||
|
|
||
| $propertyAccessor->getValue($object, 'firstName[1]'); | ||
| $this->assertSame(array('Bernhard'), $object->firstName); |
There was a problem hiding this comment.
this makes no sense as its not executed currently
There was a problem hiding this comment.
you need to catch the exception if you want to test what the tests says
be7b54d to
18759e1
Compare
18759e1 to
378db75
Compare
|
Thank you @pierredup. |
fabpot
added a commit
that referenced
this pull request
Oct 7, 2015
This PR was merged into the 2.7 branch. Discussion ---------- Added more tests for PropertyAccess | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is a follow up for [16090#issuecomment-145183635](#16090 (comment)) Commits ------- 378db75 Added more tests for PropertyAccess
| $object->firstName = array('Bernhard'); | ||
|
|
||
| try { | ||
| $propertyAccessor->getValue($object, 'firstName[1]'); |
There was a problem hiding this comment.
this is missing a fail() after wards. Otherwise the test also passed if the exception is not thrown which would be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for 16090#issuecomment-145183635