[FraworkBundle] Add missing doctrine/cache to composer.json #16159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 7, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 7, 2015
…son (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [FraworkBundle] Add missing doctrine/cache to composer.json | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- f377643 [FraworkBundle] Add missing doctrine/cache to composer.json
| @@ -30,6 +30,7 @@ | |||
| "symfony/stopwatch": "~2.3|~3.0.0", | |||
| "symfony/templating": "~2.1|~3.0.0", | |||
| "symfony/translation": "~2.8", | |||
| "doctrine/cache": "~1.0", | |||
There was a problem hiding this comment.
I'm pretty sure this is a mistake. We only reference hard-dependencies and Doctrine cache is only used AFAICS for the validator and that's even optional.
There was a problem hiding this comment.
it is used for the annotation reader (previously, the FileCachedReader of doctrine/annotations was used by default, but it changed because the class is deprecated)
There was a problem hiding this comment.
@stof is right, thus the hard dep for caching annotations
fabpot
added a commit
that referenced
this pull request
Oct 7, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] composer suggest fix | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | no Since cache is now required (See #16159), it makes no sense to suggest it Commits ------- 9786868 [FrameworkBundle] composer suggest fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.