Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Add a data: URI normalizer #16164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dunglas wants to merge 10 commits into from
Closed

[Serializer] Add a data: URI normalizer #16164

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
efa58f4
[Serializer] Add a data: URI normalizer
dunglas Oct 7, 2015
28b1e13
Fix security issue and HHVM tests.
dunglas Oct 7, 2015
790ad3a
Switch to @bgrins regex
dunglas Oct 10, 2015
b0fe18c
Tweaked the regex to match PHP data stream restrictions and added tests
dunglas Oct 10, 2015
7e5e845
Fix HHVM test
dunglas Oct 10, 2015
f207713
Fix PHPDoc
dunglas Dec 10, 2015
f4ee396
Fix @xabbuh comments
dunglas Dec 14, 2015
53e2b26
Take into account @weaverryan's comments
dunglas Jan 17, 2016
c03aa28
Minor fixes
dunglas Jan 17, 2016
68869f5
Move throw outside of the try/catch block
dunglas Jan 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PHPDoc
  • Loading branch information
@dunglas
dunglas committed Dec 10, 2015
commit f20771348c30e74be8c33c152f04e610b963d50e
2 changes: 1 addition & 1 deletion src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

/**
* Normalizes a {@see \SplFileInfo} object to a data URI.
Copy link
Copy Markdown
Member

@xabbuh xabbuh Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an

Copy link
Copy Markdown
Member Author

@dunglas dunglas Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a SplFileInfo [...] no?

Copy link
Copy Markdown
Member

@xabbuh xabbuh Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an SplFileInfo afaik

* Denormalizes a data URI to a {@see \SplFileObject} object using .
* Denormalizes a data URI to a {@see \SplFileObject} object.
*
* @author Kévin Dunglas <[email protected]>
*/
Expand Down