[ci] Collect and replay skipped tests #16184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +41,16 @@ if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit")) { | |||
| $zip->close(); | |||
| chdir("phpunit-$PHPUNIT_VERSION"); | |||
| passthru("$COMPOSER remove --no-update symfony/yaml"); | |||
| passthru("$COMPOSER require --no-update symfony/phpunit-bridge ~2.8"); | |||
There was a problem hiding this comment.
why ? The Symfony project already depend on the bridge
There was a problem hiding this comment.
This is phpunit's composer.json
There was a problem hiding this comment.
I should try removing this :)
There was a problem hiding this comment.
Well, phpunit listeners are loaded before the bootstrapp file is included, which means we have to add phpunit-bridge to phpunit's composer.json, no choice
0a0cb93 to
2926946
Compare
| passthru("$COMPOSER install --prefer-source --no-progress --ansi"); | ||
| copy('../../src/Symfony/Bridge/PhpUnit/SkippedTestsListener.php', './vendor/symfony/phpunit-bridge/SkippedTestsListener.php'); |
There was a problem hiding this comment.
This line should be removed before merging. For now, it allows testing before subtree-splitting
2954693 to
d78597e
Compare
| @@ -32,6 +33,7 @@ install: | |||
| - IF %PHP%==1 cd .. | |||
| - IF %PHP%==1 echo @php %%~dp0composer.phar %%* > composer.bat | |||
| - IF %PHP%==1 copy /Y php.ini-development php.ini-min | |||
| - IF %PHP%==1 echo max_execution_time=1200 >> php.ini-min | |||
There was a problem hiding this comment.
20 minutes is twice the time required for tests to run. This prevents blocking for appveyor queue for too long.
d78597e to
7ae2634
Compare
| passthru("$COMPOSER install --prefer-source --no-progress --ansi"); | ||
| symlink(realpath('../../src/Symfony/Bridge/PhpUnit/SkippedTestsListener.php'), './vendor/symfony/phpunit-bridge/SkippedTestsListener.php'); |
There was a problem hiding this comment.
This line should be removed before merging. For now, it allows testing before subtree-splitting
7ae2634 to
d8c8fc7
Compare
|
PR is ready for review, failures on Windows are not related |
This was referenced Oct 10, 2015
fabpot
added a commit
that referenced
this pull request
Oct 10, 2015
…d replay skipped tests (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [PhpUnitBridge] Add SkippedTestsListener to collect and replay skipped tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16184 | License | MIT | Doc PR | - Commits ------- dd640f5 [PhpUnitBridge] Add SkippedTestsListener to collect and replay skipped tests
nicolas-grekas
added a commit
that referenced
this pull request
Oct 10, 2015
…las-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [ci] Enable collecting and replaying skipped tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16184 | License | MIT | Doc PR | - Commits ------- 4032c88 [ci] Enable collecting and replaying skipped tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is targetted at speeding up our tests on appveyor by skipping
already succeeding tests when enabling addtional extensions.
Once it's confirmed it works, I'll port it to other branches.