[Yaml] deprecated non-escaped \ in double-quoted strings when parsing #16201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8823166 to
6b176d7
Compare
|
👍 |
| */ | ||
| public function unescapeCharacter($value) | ||
| { | ||
| switch ($value{1}) { | ||
| switch ($value[1]) { |
There was a problem hiding this comment.
not set when the unescaped backslash is the last character isn't it?
There was a problem hiding this comment.
Actually, a backslash at the end is not possible as this caught before this is called. I've added a test for this case and tweaked the regex here accordingly.
6b176d7 to
08b7f0a
Compare
|
👍 |
08b7f0a to
e599a72
Compare
fabpot
added a commit
that referenced
this pull request
Oct 12, 2015
…gs when parsing (fabpot) This PR was merged into the 2.8 branch. Discussion ---------- [Yaml] deprecated non-escaped \ in double-quoted strings when parsing | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a According to the YAML specs, backslashes must be escaped when used in a double-quoted string. So, `"Foo\Var"` is not valid, `"Foo\\Var"` is. This PR deprecates the old ways so that we can throw an exception in 3.0 when parsing a non-compliant YAML string in 3.0. ping @nicolas-grekas @tucksaun Commits ------- e599a72 [Yaml] deprecated non-escaped \ in double-quoted strings when parsing
fabpot
added a commit
that referenced
this pull request
Oct 12, 2015
… (fabpot) This PR was merged into the 3.0-dev branch. Discussion ---------- [Yaml] removed YAML parser \ escaping in double-quotes | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Should be rebased when #16201 is merged. Commits ------- 5dbf6bc [Yaml] removed parsing of non-escaped backslash in a double-quoted string
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the YAML specs, backslashes must be escaped when used in a double-quoted string. So,
"Foo\Var"is not valid,"Foo\\Var"is.This PR deprecates the old ways so that we can throw an exception in 3.0 when parsing a non-compliant YAML string in 3.0.
ping @nicolas-grekas @tucksaun