[TEMPLATING] relative paths in template cache #16233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $cacheDir The cache path | ||
| */ | ||
| public function __construct(FileLocatorInterface $locator, $cacheDir = null) | ||
| public function __construct(FileLocatorInterface $locator, $rootDir, $cacheDir = null) |
| @@ -36,6 +37,7 @@ public function __construct(FileLocatorInterface $locator, $cacheDir = null) | |||
| $this->cache = require $cache; | |||
| } | |||
|
|
|||
| $this->rootDir = realpath(__dir__.'/../../../../../../../../../'); | |||
There was a problem hiding this comment.
This is totally wrong. We shouldn't rely on the location Symfony is installed in.
|
Sorry, I just noticed a reference to #3079. |
|
What's the status of this? :) |
|
@rvanginneken Are you able to finish this one? |
|
@fabpot As I have not other solution; No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates are saved with relative paths. Absolute path is added on locate.