[Routing] use constants in tests #16277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/Symfony/Component/Routing/Tests/Generator/Dumper/PhpGeneratorDumperTest.php
|
Thank you @Tobion. |
|
merged and propagated to 2.8. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2015
…hp templates consistent with twig (Tobion) This PR was merged into the 2.8 branch. Discussion ---------- Unify URL generator reference type + make linking in php templates consistent with twig | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #14672 | License | MIT | Doc PR | TODO Please see ticket. Please merge #16277 first. I will then rebase this to make tests pass. Commits ------- 388fa43 [Templating] deprecate low-level RouterHelper::generate method as it's cumbersome to use constants in templates 97d6828 [Templating] introduce path and url methods in php templates to be in line with twig templates 912fc4d [Routing] deprecate the old url generator reference type values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use constants in tests instead of hardcoded values in preparation for #16276