[Yaml] deprecated usage of @ and ` at the beginning of an unquoted string #16285

fabpot · 2015-10-19T09:49:24Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#16234
License	MIT
Doc PR	n/a

stof · 2015-10-19T09:57:25Z

👍

Tobion · 2015-10-19T10:49:49Z

I'm not sure it's worth to remove the @ functionality considering the high impact as said in #16234 (comment)

I assume there will be ALOT of bundles that are affected that all would not be compatible with 3.0 without adjustments. And adding quotes arguments: - "@my_other_service" also doesn't look that nice. So maybe we should only do this change for "`" but live with the fact that @ is not according to spec.

fabpot · 2015-10-19T10:51:38Z

@Tobion we must be as compliant as possible as people use other languages (like Ruby and Python) in their stack. As adding quotes is easy enough and BC for everyone, I think we need to do this now; it's indeed going to be a bit painful but I think it's worth it.

xabbuh · 2015-10-19T10:58:00Z

src/Symfony/Component/Yaml/CHANGELOG.md

@@ -4,6 +4,7 @@ CHANGELOG
 2.8.0
 -----

+ * Deprecated usage of @ and ` at the beginning of an unquoted string


We should escape the backtick here.

Github seems to handle it just fine.

Only as long as you don't add another one in the file. They handle it only because they cannot find the corresponding one.

fabpot · 2015-10-20T06:12:17Z

ping @symfony/deciders

dunglas · 2015-10-20T06:23:37Z

👍 I agree we should do it now. However, as it will affect almost all bundles and docs out right now it would be nice to provide a rock-solid sed command to do automatically the change in the UPGRADE file.

aitboudad · 2015-10-20T09:08:15Z

👍

I see another case (the usage of % at the beginning of an unquoted string) where I think we should deprecate.

services:
    foo.baz:
        class: %baz_class%

xabbuh · 2015-10-20T09:12:30Z

@aitboudad Afaik there is nothing special with the % character in scalars (there was in YAML 1.1 IIRC though).

Edit: Revoked my +1 because of the failing tests (see below).

xabbuh · 2015-10-20T09:13:50Z

It seems that we have some fixture files that need an update.

aitboudad · 2015-10-20T09:32:50Z

@xabbuh you're right, I tested with 1.2

stof · 2015-10-20T09:54:53Z

@aitboudad the reason why we had to quote them in the documentation is because Pygments implemented its Yaml syntax highlighter based on Yaml 1.1, and has not updated it for 1.2. But it is indeed not an issue.

OskarStark · 2015-10-22T14:28:00Z

👍 @dunglas , such sed command would be great 😄

This PR was squashed before being merged into the 2.3 branch (closes #5843). Discussion ---------- Fixed the YAML syntax for service references | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - See symfony/symfony#16285 and symfony/symfony#16353 for context. I've just found two issues, but it's possible that this syntax is used in more places. Commits ------- daeda56 Fixed the YAML syntax for service references

…ring

… an unquoted string (fabpot) This PR was merged into the 2.8 branch. Discussion ---------- [Yaml] deprecated usage of @ and ` at the beginning of an unquoted string | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #16234 | License | MIT | Doc PR | n/a Commits ------- 7fee29f [Yaml] deprecated usage of @ and ` at the beginning of an unquoted string

This PR was merged into the 2.8 branch. Discussion ---------- [Yaml] escape backtick in markdown changelog | Q | A | ------------- | --- | Fixed tickets | #16285 | License | MIT Commits ------- a613b0d [Yaml] escape backtick in markdown changelog

Error Message: The reserved indicator "@" cannot start a plain scalar; you need to quote the scalar at line Related to pull request: symfony/symfony#16285

@see

@see symfony/symfony#16285

gepo · 2016-01-14T11:20:12Z

Oneliner to change it in all Yaml files:

find ./ -name '*.yml' -exec sed -i '' -E 's/([^"])@([a-z\._]+)($|\]| |,)/\1"@\2"\3/g' {} +

OskarStark · 2016-01-14T11:36:21Z

thank you @gepo

TomasVotruba · 2016-01-14T11:38:18Z

@gepo Thanks for a tip

This type of use was deprecated in symfony 2.8 and will be dropped in 3.x. Also see: symfony/symfony#16285 PHPBB3-14717

carsonbot added the Status: Needs Review label Oct 19, 2015

fabpot mentioned this pull request Oct 19, 2015

YAML incorrectly parses tags starting with @ and ` #16234

Closed

xabbuh reviewed Oct 19, 2015
View reviewed changes

paul999 mentioned this pull request Oct 19, 2015

Add warning for invalid YAML phpbb/epv#42

Closed

aitboudad added the Yaml label Oct 20, 2015

javiereguiluz mentioned this pull request Oct 27, 2015

Fixed the YAML syntax for service references symfony/symfony-docs#5843

Closed

fabpot force-pushed the yaml-deps branch 3 times, most recently from 162f095 to 8df1aa9 Compare October 28, 2015 04:18

[Yaml] deprecated usage of @ and ` at the beginning of an unquoted st…

7fee29f

…ring

fabpot force-pushed the yaml-deps branch from 8df1aa9 to 7fee29f Compare October 28, 2015 04:32

fabpot merged commit 7fee29f into symfony:2.8 Oct 28, 2015

xabbuh mentioned this pull request Oct 28, 2015

[Yaml] escape backtick in markdown changelog #16371

Merged

fabpot mentioned this pull request Nov 16, 2015

Release v2.8.0-BETA1 #16550

Merged

jenkoian mentioned this pull request Nov 17, 2015

Add quote to yaml reserved chars in fixtures. nelmio/alice#290

Merged

pguso added a commit to pguso/LswApiCallerBundle that referenced this pull request Dec 17, 2015

compoatibility to symfony 3.0

29db89c

Error Message: The reserved indicator "@" cannot start a plain scalar; you need to quote the scalar at line Related to pull request: symfony/symfony#16285

pguso mentioned this pull request Dec 17, 2015

compatibility to symfony 3.0 leaseweb/LswApiCallerBundle#21

Merged

jakzal mentioned this pull request Jan 2, 2016

Config/behat yml quoting phpspec/phpspec#833

Merged

AlexDpy added a commit to nuxia/AclBundle that referenced this pull request Jan 10, 2016

Quoted all usage of @ at the beginning of a string in yaml files

6e6cc44

@see symfony/symfony#16285

gepo mentioned this pull request Jan 14, 2016

Symfony 3.0 compatibility mmoreram/GearmanBundle#166

Closed

marc1706 added a commit to marc1706/phpbb that referenced this pull request Jul 23, 2016

[ticket/14717] Quote strings beginning with @ or % in yaml definitions

89461d9

This type of use was deprecated in symfony 2.8 and will be dropped in 3.x. Also see: symfony/symfony#16285 PHPBB3-14717

marc1706 mentioned this pull request Jul 23, 2016

[ticket/14717] Quote strings beginning with @ or % in yaml definitions phpbb/phpbb#4390

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Yaml] deprecated usage of @ and ` at the beginning of an unquoted string #16285

[Yaml] deprecated usage of @ and ` at the beginning of an unquoted string #16285

fabpot commented Oct 19, 2015

stof commented Oct 19, 2015

Tobion commented Oct 19, 2015

fabpot commented Oct 19, 2015

xabbuh Oct 19, 2015

fabpot Oct 19, 2015

stof Oct 19, 2015

fabpot commented Oct 20, 2015

dunglas commented Oct 20, 2015

aitboudad commented Oct 20, 2015

xabbuh commented Oct 20, 2015

xabbuh commented Oct 20, 2015

aitboudad commented Oct 20, 2015

stof commented Oct 20, 2015

OskarStark commented Oct 22, 2015

gepo commented Jan 14, 2016

OskarStark commented Jan 14, 2016

TomasVotruba commented Jan 14, 2016

[Yaml] deprecated usage of @ and ` at the beginning of an unquoted string #16285

[Yaml] deprecated usage of @ and ` at the beginning of an unquoted string #16285

Conversation

fabpot commented Oct 19, 2015

stof commented Oct 19, 2015

Tobion commented Oct 19, 2015

fabpot commented Oct 19, 2015

xabbuh Oct 19, 2015

Choose a reason for hiding this comment

fabpot Oct 19, 2015

Choose a reason for hiding this comment

stof Oct 19, 2015

Choose a reason for hiding this comment

fabpot commented Oct 20, 2015

dunglas commented Oct 20, 2015

aitboudad commented Oct 20, 2015

xabbuh commented Oct 20, 2015

xabbuh commented Oct 20, 2015

aitboudad commented Oct 20, 2015

stof commented Oct 20, 2015

OskarStark commented Oct 22, 2015

gepo commented Jan 14, 2016

OskarStark commented Jan 14, 2016

TomasVotruba commented Jan 14, 2016