[VarDumper] Fix return type and anonymous classes dumping #16291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest adding a test covering this for PHP 7+ |
31d09ac to
c5b6751
Compare
|
test added |
c5b6751 to
b42b03a
Compare
|
This PR now also fixes dumping PHP7 anonymous classes. |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 20, 2015
…(nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [VarDumper] Fix return type and anonymous classes dumping | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I missed that `getReturnType` returns a `ReflectionType` instance that should be casted to string. Commits ------- b42b03a [VarDumper] Fix return type and anonymous classes dumping
| */ | ||
| public function testAnonymousClass() | ||
| { | ||
| $c = eval('return new class extends stdClass { private $foo = "foo"; };'); |
There was a problem hiding this comment.
what about an anonymous class not extending any parent class ? Is it valid ?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed that
getReturnTypereturns aReflectionTypeinstance that should be casted to string.