[DependencyInjection] Unescape parameters for all types of injection #16295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand what you are trying to fix here |
|
Migth be clearer with a simple example: https://gist.github.com/Nicofuma/a7672bf0776efb2eaa5f while we are expecting: |
|
Bump, this is a real issue for us as it throws an error to some of our users - because they have a % in their database password - each time they clear the cache. |
I've had a few users of phpBB, experiencing the issue with the % character, try the changes in the commit and it resolved the problem for them. |
|
Bump again @stof could you give this PR another look please? |
|
👍 |
|
Thank you @Nicofuma. |
fabpot
added a commit
that referenced
this pull request
Nov 19, 2015
… injection (Nicofuma) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] Unescape parameters for all types of injection | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The parameters must be escaped when injected in the container. But they are only unescaped when the container is dumped and when these parameters are used in the service constructor. We need to unescape them every time their are injected (constructor, setter and property injection) Commits ------- 331a046 [DependencyInjection] Unescape parameters for all types of injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters must be escaped when injected in the container.
But they are only unescaped when the container is dumped and when these parameters are used in the service constructor.
We need to unescape them every time their are injected (constructor, setter and property injection)