Fix the FrameworkBundle dependencies #16321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the new ClassCacheCacheWarmer, the ClassLoader component is now a required dependency of the bundle.
|
Note that this fixes the build on Travis, but we still have a few failures on AppVeyor, which should also be debugged (but separately) |
|
👍 |
|
👍 Status: Reviewed |
|
I already debugged appveyor: #16288 is the fix |
|
👍 |
|
Thank you @stof. |
Tobion
added a commit
that referenced
this pull request
Oct 23, 2015
This PR was merged into the 2.8 branch. Discussion ---------- Fix the FrameworkBundle dependencies | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Due to the new ClassCacheCacheWarmer, the ClassLoader component is now a required dependency of the bundle. See the current test failures for component builds (TwigBundle and SecurityBundle tests are triggering fatal errors because of the missing class) Commits ------- 02584c2 Fix the FrameworkBundle dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the new ClassCacheCacheWarmer, the ClassLoader component is now a
required dependency of the bundle.
See the current test failures for component builds (TwigBundle and SecurityBundle tests are triggering fatal errors because of the missing class)