[Bridge\PhpUnit] Fix clock-mock registration #16455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Nov 4, 2015
nicolas-grekas
added a commit
that referenced
this pull request
Nov 4, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Bridge\PhpUnit] Fix clock-mock registration | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Once a method has been executed, PHP ignores any new function that could be injected in the namespace afterwards (HHVM does not ignore them btw). Which means we have to inject clock-mocking functions into all clock-mocked namespaces before any actual implementation is used in that namespace. This PR does it. Commits ------- 0a6a10a [Bridge\PhpUnit] Fix clock-mock registration
nicolas-grekas
added a commit
that referenced
this pull request
Nov 4, 2015
(nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [HttpKernel] Clean clock-mock injection, replaced by #16455 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I really hope this PR is the last one on the clock-mocking topic! Commits ------- 388534e [HttpKernel] Clean clock-mock injection, replaced by #16455
nicolas-grekas
added a commit
that referenced
this pull request
Nov 4, 2015
* 2.3: [HttpKernel] Clean clock-mock injection, replaced by #16455 Conflicts: src/Symfony/Component/HttpKernel/Tests/Fragment/FragmentHandlerTest.php
nicolas-grekas
added a commit
that referenced
this pull request
Nov 4, 2015
* 2.7: [HttpKernel] Clean clock-mock injection, replaced by #16455
nicolas-grekas
added a commit
that referenced
this pull request
Nov 4, 2015
* 2.8: [HttpKernel] Clean clock-mock injection, replaced by #16455 [Bridge\PhpUnit] Fix clock-mock registration
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Nov 4, 2015
* 2.7: [HttpKernel] Clean clock-mock injection, replaced by symfony#16455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a method has been executed, PHP ignores any new function that could be injected in the namespace afterwards (HHVM does not ignore them btw).
Which means we have to inject clock-mocking functions into all clock-mocked namespaces before any actual implementation is used in that namespace.
This PR does it.