improve BrowserKit test coverage p1 #16549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve BrowserKit test coverage p2 improve BrowserKit test coverage p3 improve BrowserKit test coverage p4 improve BrowserKit test coverage p5
|
shouldn't this be merged into older branches to cover it in all relevant versions ? |
|
You mean all supported version? I can base my next PR's on 2.7 if you want. |
|
2.3 is still maintained. |
|
IMO, it makes sense to add tests in 2.3 |
|
Ok, I'll rebase it against 2.3 |
|
Here is a new PR #17069 |
Tobion
added a commit
that referenced
this pull request
Dec 24, 2015
This PR was merged into the 2.3 branch. Discussion ---------- improve BrowserKit test coverage p1 Hi, This PR improves BrowserKit test coverage. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT I rebased previous PR #16549 to 2.3 Commits ------- 0261b48 improve BrowserKit test coverage p1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR improves BrowserKit test coverage.