[Serializer] add missing unit tests related to Encoder #16557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I've just merged another PR which also added some tests, can you rebase? Thanks. |
ed612fd to
5f4769f
Compare
5f4769f to
7418d29
Compare
|
Done. I tried to merge in a relevant way the 2 versions of |
|
Thank you @FlorianLB. |
fabpot
added a commit
that referenced
this pull request
Nov 20, 2015
…FlorianLB) This PR was merged into the 2.8 branch. Discussion ---------- [Serializer] add missing unit tests related to Encoder Add some missing unit tests on the Serializer component. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 7418d29 [Serializer] add missing unit tests related to Encoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some missing unit tests on the Serializer component.