Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Fix PropertyInfo extractor namespace in framework bundle #16573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2015

Conversation

jvasseur
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The only failing test I had was because of the missing zendframework/zend-stdlib, adding it made tests pass.

@@ -13,7 +13,8 @@
</service>

<!-- Extractor -->
<service id="property_info.reflection_extractor" class="Symfony\Component\PropertyInfo\ReflectionExtractor" public="false">
<service id="property_info.reflection_extractor" class="Symfony\Component\PropertyInfo\Extractor
\ReflectionExtractor" public="false">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be on one line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jvasseur jvasseur force-pushed the fix-extractor-namespace branch from affa76d to d04984a Compare November 18, 2015 08:40
@fabpot
Copy link
Member

fabpot commented Nov 18, 2015

Thank you @jvasseur.

@fabpot fabpot merged commit d04984a into symfony:2.8 Nov 18, 2015
fabpot added a commit that referenced this pull request Nov 18, 2015
…framework bundle (jvasseur)

This PR was merged into the 2.8 branch.

Discussion
----------

[FrameworkBundle] Fix PropertyInfo extractor namespace in framework bundle

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The only failing test I had was because of the missing zendframework/zend-stdlib, adding it made tests pass.

Commits
-------

d04984a Fix PropertyInfo extractor namespace in framework bundle
@jvasseur jvasseur deleted the fix-extractor-namespace branch November 18, 2015 10:01
This was referenced Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants