Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for HTTP status code 418 back #16585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2015
Merged

Add support for HTTP status code 418 back #16585

merged 1 commit into from
Nov 18, 2015

Conversation

dawehner
Copy link
Contributor

See https://gist.github.com/anonymous/a863d7b493c4b09733ec what this results into

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets 16584
License MIT
Doc PR

@dawehner dawehner changed the title add it back Add support for HTTP status code 418 back Nov 18, 2015
@Tobion
Copy link
Contributor

Tobion commented Nov 18, 2015

Ref. #15796

@dawehner
Copy link
Contributor Author

So yeah #15796 was kind of a BC break indeed, I mean it broke at least some tests

@fabpot
Copy link
Member

fabpot commented Nov 18, 2015

Thank you @dawehner.

@fabpot fabpot merged commit db5fbe0 into symfony:2.8 Nov 18, 2015
fabpot added a commit that referenced this pull request Nov 18, 2015
@fabpot
bug #16585 Add support for HTTP status code 418 back (dawehner)
36bf706 
This PR was merged into the 2.8 branch.

Discussion
----------

Add support for HTTP status code 418 back

See https://gist.github.com/anonymous/a863d7b493c4b09733ec what this results into

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | 16584
| License       | MIT
| Doc PR        |

Commits
-------

db5fbe0 add it back
@ghost
Copy link

ghost commented Nov 20, 2015

@dawehner @fabpot
What's about HTTP code 306? It was removed too. dupuchba@3226569

And is the change of the text of some HTTP codes not a BC break?

@ghost ghost mentioned this pull request Nov 20, 2015
Closed
@dawehner
Copy link
Contributor Author

Sure, why not ...


And is the change of the text of some HTTP codes not a BC break?

Well, the HTTP standard says that you should not take care about it. IMHO
though having a broken interaction with apache is way more important than
strict BC here.

On Fri, Nov 20, 2015 at 5:14 PM, JHGitty [email protected] wrote:

@dawehner https://github.com/dawehner @fabpot
https://github.com/fabpot
What's about HTTP code 306? It was removed too.
dupuchba/symfony@3226569#diff-a8f7745712c744a53020ed9c09bd68bcL84
dupuchba@3226569#diff-a8f7745712c744a53020ed9c09bd68bcL84

And is the change of the text of some HTTP codes not a BC break?

—
Reply to this email directly or view it on GitHub
#16585 (comment).

This was referenced Nov 30, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dawehner @Tobion @fabpot @carsonbot