Sent out a status text for unknown HTTP headers. #16588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See https://bz.apache.org/bugzilla/show_bug.cgi?id=44995 and https://bz.apache.org/bugzilla/show_bug.cgi?id=54946 on why Apache refuses empty |
| @@ -454,7 +454,7 @@ public function setStatusCode($code, $text = null) | |||
| } | |||
|
|
|||
| if (null === $text) { | |||
| $this->statusText = isset(self::$statusTexts[$code]) ? self::$statusTexts[$code] : ''; | |||
| $this->statusText = isset(self::$statusTexts[$code]) ? self::$statusTexts[$code] : 'Unknown status text'; | |||
There was a problem hiding this comment.
Unknow Status only (with caps)? text looks redondant
There was a problem hiding this comment.
or maybe all lowercase to differenciate from regular status texts that are "ucwords"
There was a problem hiding this comment.
So let's go with 'unknown status'?
|
Thank you @dawehner. |
fabpot
added a commit
that referenced
this pull request
Nov 19, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #16588). Discussion ---------- Sent out a status text for unknown HTTP headers. * The HTTP RFC explains that header('HTTP/1.1 418 ') should be fine, see http://www.w3.org/Protocols/rfc2616/rfc2616-sec6.html#sec6.1 * Apache itself though is broken, see https://gist.github.com/anonymous/a863d7b493c4b09733ec The fix is to sent out some status text, when we don't know a better text. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- eec6fbc Sent out a status text for unknown HTTP headers.
|
Doesn't it say it's fixed in Apache? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is to sent out some status text, when we don't know a better text.