Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Suggested Process dependency #16650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2015
Merged

Suggested Process dependency #16650

merged 1 commit into from
Dec 5, 2015

Conversation

gnugat
Copy link
Contributor

@gnugat gnugat commented Nov 24, 2015

The server:run command requires the Process component.

The `server:run` command requires the Process component.
@stof
Copy link
Member

stof commented Nov 24, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Nov 24, 2015

We also could provide a better error message in the command when the Process component is not installed.

@jakzal
Copy link
Contributor

jakzal commented Nov 24, 2015

👍

@stof
Copy link
Member

stof commented Nov 24, 2015

@xabbuh this is a good idea

@stof
Copy link
Member

stof commented Dec 5, 2015

Thank you @gnugat.

@stof stof merged commit 7c1231a into symfony:2.8 Dec 5, 2015
stof added a commit that referenced this pull request Dec 5, 2015
This PR was merged into the 2.8 branch.

Discussion
----------

Suggested Process dependency

The `server:run` command requires the Process component.

Commits
-------

7c1231a Suggested Process dependency
fabpot added a commit that referenced this pull request Dec 7, 2015
…ess component is missing (gnugat, xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] Disable the server:run command when Process component is missing

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This also backports the improvement for the `suggest` section from #16650 to the `2.3` branch.

Commits
-------

99d1741 disable server:run cmd without Process component
604174c Suggested Process dependency
fabpot added a commit that referenced this pull request Dec 7, 2015
…ocess component is missing (gnugat, xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Disable built-in server commands when Process component is missing

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This also backports the improvement for the `suggest` section from #16650 to the `2.7` branch and improves it by also mentioning the other built-in server commands.

Commits
-------

972c4ca disable server commands without Process component
dd82b64 list all server command names in suggestion
d18fb9b Suggested Process dependency
@gnugat gnugat deleted the patch-1 branch December 11, 2015 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants