-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Suggested Process dependency #16650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Suggested Process dependency #16650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `server:run` command requires the Process component.
👍 |
We also could provide a better error message in the command when the Process component is not installed. |
👍 |
@xabbuh this is a good idea |
Thank you @gnugat. |
stof
added a commit
that referenced
this pull request
Dec 5, 2015
This PR was merged into the 2.8 branch. Discussion ---------- Suggested Process dependency The `server:run` command requires the Process component. Commits ------- 7c1231a Suggested Process dependency
This was referenced Dec 6, 2015
fabpot
added a commit
that referenced
this pull request
Dec 7, 2015
…ess component is missing (gnugat, xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] Disable the server:run command when Process component is missing | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This also backports the improvement for the `suggest` section from #16650 to the `2.3` branch. Commits ------- 99d1741 disable server:run cmd without Process component 604174c Suggested Process dependency
fabpot
added a commit
that referenced
this pull request
Dec 7, 2015
…ocess component is missing (gnugat, xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Disable built-in server commands when Process component is missing | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This also backports the improvement for the `suggest` section from #16650 to the `2.7` branch and improves it by also mentioning the other built-in server commands. Commits ------- 972c4ca disable server commands without Process component dd82b64 list all server command names in suggestion d18fb9b Suggested Process dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
server:run
command requires the Process component.