[SecurityBundle] make ACL an optional dependency #16694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2015
fabpot
added a commit
that referenced
this pull request
Nov 26, 2015
…t used (Tobion) This PR was merged into the 2.3 branch. Discussion ---------- [SecurityBundle] disable the init:acl command if ACL is not used | Q | A | ------------- | --- | Bug fix? | somewhat | New feature? | somewhat | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - Related to #16694 but this should go in 2.3 IMO because it was just forgotten. The other acl command already has this logic: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/SecurityBundle/Command/SetAclCommand.php#L36 It ensures the command list is not flooded with unusable commands. Commits ------- 55f84a3 [SecurityBundle] disable the init:acl command if ACL is not used
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [SecurityBundle] make ACL an optional dependency | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - Fixes #14718 (comment). Together with doctrine/DoctrineCacheBundle#77 we do not have ACL in the symfony-standard 3.0 by default anymore. Commits ------- fc66283 [SecurityBundle] make ACL an optional dependency
| @@ -116,6 +116,10 @@ public function load(array $configs, ContainerBuilder $container) | |||
|
|
|||
| private function aclLoad($config, ContainerBuilder $container) | |||
| { | |||
| if (!interface_exists('Symfony\Component\Security\Acl\Model\AclInterface')) { | |||
| throw new \LogicException('You must install symfony/security-acl in order to use the ACL functionality.'); | |||
There was a problem hiding this comment.
Should be \RuntimeException() IMO.
There was a problem hiding this comment.
Doesn't really matter and its the same as in doctrine/DoctrineCacheBundle#77
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14718 (comment).
Together with doctrine/DoctrineCacheBundle#77 we do not have ACL in the symfony-standard 3.0 by default anymore.