Fix BC for the default root form name #16758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block prefix is used, to match the previous behavior when using a custom block prefix.
|
👍 |
1 similar comment
|
👍 |
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2015
This PR was merged into the 2.8 branch. Discussion ---------- Fix BC for the default root form name | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15760 | License | MIT | Doc PR | n/a The block prefix is used, to match the previous behavior when using a custom block prefix. The form type is now retrieved twice from the registry here, but this should not be an issue: - unnamed forms are created only at the root, so only once per form at most (child forms are always named explicitly) - the registry caches the resolved type, so the second access is just accessing the key in the array and returning it Commits ------- 0a54d09 Fix BC for the default root form name
|
this code can then be cleaned in the master branch, as ResolvedFormTypeInterface contains the getBlockPrefix method, and so it is always defined |
soullivaneuh
referenced
this pull request
in genemu/GenemuFormBundle
Jul 6, 2016
fix deprecated function in Select2Type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block prefix is used, to match the previous behavior when using a custom block prefix.
The form type is now retrieved twice from the registry here, but this should not be an issue: