Upgrade information for the choice_value option #16849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Disabled' => Status::DISABLED, | ||
| 'Ignored' => Status::IGNORED, | ||
| ), | ||
| // choices_as_values will default to true in Symfony 3.0 |
There was a problem hiding this comment.
and setting it to something different is deprecated
There was a problem hiding this comment.
Updated accordingly.
There was a problem hiding this comment.
will default -> defaults
|
@xabbuh Is this good to go? |
|
👍 LGTM |
| After: | ||
|
|
||
| ```php | ||
| $form->add('status', 'choice', array( |
There was a problem hiding this comment.
'choice' -> ChoiceType::class
|
@nicolas-grekas Good catch, updated. |
|
Thank you @peterrehm. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 18, 2015
This PR was merged into the 2.8 branch. Discussion ---------- Upgrade information for the choice_value option | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Relates to #14825 and #14377. The behaviour was changed with #16681 so a not in the upgrade information makes sense to me. Commits ------- 28675c9 Reflected the change of the choice_value option in the Upgrade information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #14825 and #14377. The behaviour was changed with #16681 so a not in the upgrade information makes sense to me.