[Process] Always call proc_close #16875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b30620 to
8933cdc
Compare
| { | ||
| $this->processPipes->close(); | ||
| if (is_resource($this->process)) { | ||
| if ($wait && is_resource($this->process)) { | ||
| $exitcode = proc_close($this->process); |
There was a problem hiding this comment.
Wouldn't this lead to zombie processes now?
There was a problem hiding this comment.
could be, but only in cases where sending SIGTERM + SIGKILL did not have any effect, which means the Process object is stuck is an infinite waiting loop.
|
proc_open is now always called, ready again :) |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 8, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [Process] Always call proc_close | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15617 | License | MIT | Doc PR | - This should fix one more transient test, and a wrong behavior. Commits ------- ccb67d7 [Process] Always call proc_close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix one more transient test, and a wrong behavior.