[HttpKernel] HttpCache: remove an ESI instance checking #16970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
| * @return SurrogateInterface A Surrogate instance | ||
| */ | ||
| public function getSurrogate() | ||
| { | ||
| if (!$this->surrogate instanceof Esi) { | ||
| throw new \LogicException('This instance of HttpCache was not set up to use ESI as surrogate handler. You must overwrite and use createSurrogate'); |
There was a problem hiding this comment.
What is createSurrogate? I cannot find such definition. this exception still doesn't make sense to me in 2.7
Ref. #15306 (comment)
There was a problem hiding this comment.
There was a problem hiding this comment.
but that is in frameworkbundle. httpkernel doesn't know about this method.
|
Thank you @voronkovich. |
Tobion
added a commit
that referenced
this pull request
Dec 12, 2015
…oronkovich) This PR was merged into the 3.0 branch. Discussion ---------- [HttpKernel] HttpCache: remove an ESI instance checking | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no This checking was added by this commit 32d964b, but now it's not needed Commits ------- 7528134 Removed ESI instance check
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checking was added by this commit 32d964b, but now it's not needed