[HttpFoundation] Added the ability of using BinaryFileResponse with stream wrappers #16971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Dec 11, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #12990 #13187 |
| License | MIT |
| Doc PR | ~ |
1 task
| @@ -192,6 +192,10 @@ public function prepare(Request $request) | |||
| // Use X-Sendfile, do not send any content. | |||
| $type = $request->headers->get('X-Sendfile-Type'); | |||
| $path = $this->file->getRealPath(); | |||
| // Fall back to scheme://path for stream wrapped locations. | |||
| if (empty($path)) { | |||
There was a problem hiding this comment.
just check if is equal false
…s when using X-Sendfile
74246be to
1da3d61
Compare
|
👍 Status: Reviewed |
|
Thank you @jakzal. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 18, 2015
…onse with stream wrappers (jakzal, Sander-Toonen) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] Added the ability of using BinaryFileResponse with stream wrappers | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12990 #13187 | License | MIT | Doc PR | ~ Commits ------- 1da3d61 [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile dd129b7 [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers
|
Thank you @Sander-Toonen |
This was referenced Dec 26, 2015
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.