Webprofiler add status code to search form #17125
Conversation
|
Following the PR #15111 |
| $end = $request->query->get('end', $session->get('_profiler_search_end')); | ||
| $limit = $request->query->get('limit', $session->get('_profiler_search_limit')); | ||
| $token = $request->query->get('token', $session->get('_profiler_search_token')); | ||
| $ip = $session->get('_profiler_search_ip'); |
|
Status: Needs work |
|
@sstok Oops ! Mistake after the rebase, FIxed. |
| @@ -16,6 +16,11 @@ | |||
| </div> | |||
|
|
|||
| <div class="form-group"> | |||
| <label for="status_code">Status</label> | |||
| <input type="text" name="status_code" id="status_code" value="{{ status_code }}"> | |||
There was a problem hiding this comment.
Why not using a number input here?
|
ping @sstok Can I have some news please ? |
| { | ||
| $profiler = new Profiler($this->storage); | ||
|
|
||
| $this->assertCount(0, $profiler->find(null, null, null, null, null, null, 204)); |
There was a problem hiding this comment.
AFAIU, you do not test anything here. Can you add a test where the count is non-zero?
|
@oktapodia your pull request looks good and the proposed feature is nice! We just need a final push to finish it. Do you think you can add the test asked for by Fabien? Thanks. |
|
Status: needs work |
|
I think there are some problems with your tests. |
|
Try to rebase on master. |
|
@Ener-Getick Thanks but my PR is not mergeable if I rebase on master |
|
This is a new feature so it will be merged in master anyway. Try to rebase it on 3.0 otherwise. |
|
Same problem :( |
|
It's apparently not related to your PR (see https://github.com/symfony/symfony/branches). So don't worry ;) |
|
Failed tests have been fixed. I've played with this feature and it works as expected:
👍 Status: reviewed |
|
👍 |
|
Thanks @javiereguiluz |
|
Thank you @oktapodia. |
This PR was submitted for the 3.0 branch but it was merged into the 3.1-dev branch instead (closes #17125). Discussion ---------- Webprofiler add status code to search form | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13034 | License | MIT With this PR, in the web profiler, you can filter by HTTP status codes. *Before filter*  *After filter*  Commits ------- 7d3700a Webprofiler add status code to search form
|
👍 |
With this PR, in the web profiler, you can filter by HTTP status codes.
Before filter
After filter
