[Serializer] Unset object_to_populate after using it #17281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -279,7 +279,7 @@ protected function prepareForDenormalization($data) | |||
| * Instantiates an object using constructor parameters when needed. | |||
| * | |||
| * This method also allows to denormalize data into an existing object if | |||
| * it is present in the context with the object_to_populate key. | |||
| * it is present in the context with the object_to_populate key then remove this key. | |||
There was a problem hiding this comment.
This sentence doesn't sound right anymore.
|
should be merged in 2.7, right? |
|
Yes |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Jan 12, 2016
…nglas) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #17281). Discussion ---------- [Serializer] Unset object_to_populate after using it | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The `object_to_populate` key must be unset after using it to avoid problems when normalizing sub objects. Needed for #17193. Commits ------- ff18b68 [Serializer] Unset object_to_populate after using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
object_to_populatekey must be unset after using it to avoid problems when normalizing sub objects. Needed for #17193.