Codestin Search App

GuilhemN · 2016-01-09T18:52:56Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#17256
License	MIT

Following #17133, this PR deprecates using unsupported keywords on alias definition.

For example the following examples will trigger deprecations:

<?xml version="1.0" encoding="utf-8"?>
<container>
  <services>
    <service id="bar" alias="foo" class="Foo">
        <tag name="foo.bar" />
    </service>
  </services>
</container>

services:
    bar:
        alias: foo
        parent: quz

Taluu · 2016-01-10T12:00:10Z

The yaml test is not in the scope of this PR...

Anyway, I'm not sure we should cry if these attributees are set, they will be ignored anyway..

GuilhemN · 2016-01-10T12:13:23Z

@Taluu the goal is the same as described in #17133: avoid mistakes and simplify debugging.

jakzal · 2016-01-11T08:57:08Z

Any reason getAttribute() is used here instead of hasAttribute()?

No I didn't know this function

jakzal · 2016-01-12T11:25:48Z

I'd improve the second sentence slightly in all these deprecation messages and say "The XmlFileLoader object will raise an exception in Symfony 4.0, instead of silently ignoring unsupported attributes.".

Currently the message says "will raise an exception instead" but it doesn't say instead of what.

👍 updated.

nicolas-grekas · 2016-01-13T09:17:57Z

👍
Status: reviewed

xabbuh · 2016-01-14T16:14:07Z

missing documentation for the $file parameter

xabbuh · 2016-01-14T16:18:25Z

I would remove "object" from "The YamlFileLoader object will [...]" (same for the XmlFileLoader messages).

Status: Needs work

…lias

xabbuh · 2016-01-14T17:37:01Z

There seem to be trailing witespaces.

Oops you're right

xabbuh · 2016-01-14T18:04:09Z

👍

Status: Reviewed

GuilhemN · 2016-01-16T14:09:09Z

ping

fabpot · 2016-01-16T14:18:58Z

Thank you @Ener-Getick.

carsonbot added the Status: Needs Review label Jan 9, 2016

GuilhemN force-pushed the ALIAS branch from e5f11cd to a090d0c Compare January 9, 2016 18:54

jakzal reviewed Jan 11, 2016
View reviewed changes

GuilhemN force-pushed the ALIAS branch from a090d0c to a208137 Compare January 11, 2016 19:54

xabbuh added the DependencyInjection label Jan 12, 2016

jakzal reviewed Jan 12, 2016
View reviewed changes

GuilhemN force-pushed the ALIAS branch from a208137 to ba2f232 Compare January 12, 2016 11:36

carsonbot added Status: Reviewed and removed Status: Needs Review labels Jan 13, 2016

xabbuh reviewed Jan 14, 2016
View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Jan 14, 2016

GuilhemN force-pushed the ALIAS branch from ba2f232 to 21460c5 Compare January 14, 2016 17:14

[DependencyInjection] Deprecate unsupported attributes/elements for a…

b5cd41a

…lias

GuilhemN force-pushed the ALIAS branch from 21460c5 to b5cd41a Compare January 14, 2016 17:27

xabbuh reviewed Jan 14, 2016
View reviewed changes

Fix CS

8c3b92c

carsonbot added Status: Reviewed and removed Status: Needs Work labels Jan 14, 2016

Uh oh!

Conversation

GuilhemN commented Jan 9, 2016

Uh oh!

Taluu commented Jan 10, 2016

Uh oh!

GuilhemN commented Jan 10, 2016

Uh oh!

jakzal Jan 11, 2016

Choose a reason for hiding this comment

Uh oh!

GuilhemN Jan 11, 2016

Choose a reason for hiding this comment

Uh oh!

jakzal Jan 12, 2016

Choose a reason for hiding this comment

Uh oh!

GuilhemN Jan 12, 2016

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commented Jan 13, 2016

Uh oh!

xabbuh Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Jan 14, 2016

Uh oh!

xabbuh Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

GuilhemN Jan 14, 2016

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Jan 14, 2016

Uh oh!

GuilhemN commented Jan 16, 2016

Uh oh!

fabpot commented Jan 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants