Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Add a new DateTime normalizer#17411

Merged
dunglas merged 1 commit into
symfony:masterfrom
dunglas:normalizer_datetime
Jan 22, 2016
Merged

[Serializer] Add a new DateTime normalizer#17411
dunglas merged 1 commit into
symfony:masterfrom
dunglas:normalizer_datetime

Conversation

@dunglas
Copy link
Copy Markdown
Member

@dunglas dunglas commented Jan 17, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR todo

This PR add support for dates and times to the Normalizer component. It supports all date and time formats supported by PHP. Dates and times are normalized in the RFC 3339 format by default. The output format can be customized using the $context parameter. The default format can be changed using a constructor parameter.

Usage:

use Symfony\Component\Serializer\Normalizer\DateTimeNormalizer;
use Symfony\Component\Serializer\Serializer;

$serializer = new Serializer(array(new DateTimeNormalizer()));

echo $serializer->normalize(new \DateTimeImmutable('2016/01/01'));
// 2016-01-01T00:00:00+00:00

echo $serializer->normalize(new \DateTime('2016/01/01'));
// 2016-01-01T00:00:00+00:00

echo $serializer->normalize(new \DateTime('2016/01/01'), null, array(DateTimeNormalizer::FORMAT_KEY => 'Y'))
// 2016

var_dump($serializer->denormalize('2016-01-01T00:00:00+00:00', \DateTimeInterface::class));
// class DateTimeImmutable#1 (3) {
//   public $date =>
//   string(26) "2016-01-01 00:00:00.000000"
//   public $timezone_type =>
//   int(1)
//   public $timezone =>
//   string(6) "+00:00"
// }

var_dump($serializer->denormalize('2016-01-01T00:00:00+00:00', \DateTime::class));
// class DateTime#1 (3) {
//   public $date =>
//   string(26) "2016-01-01 00:00:00.000000"
//   public $timezone_type =>
//   int(1)
//   public $timezone =>
//   string(6) "+00:00"
// }

Toflar
Toflar reviewed Jan 18, 2016
View reviewed changes
Comment thread src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php Outdated
Copy link
Copy Markdown
Contributor

@Toflar Toflar Jan 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] implement [...] :-)

@GuilhemN
Copy link
Copy Markdown
Contributor

GuilhemN commented Jan 19, 2016

Amazing! 👍

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Jan 20, 2016

👍

@derrabus
Copy link
Copy Markdown
Member

derrabus commented Jan 20, 2016

❤️

@stof
Copy link
Copy Markdown
Member

stof commented Jan 20, 2016

👍

dosten
dosten reviewed Jan 20, 2016
View reviewed changes
Comment thread src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php Outdated
Copy link
Copy Markdown
Contributor

@dosten dosten Jan 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rename this to $e following this PR #14937

Copy link
Copy Markdown
Member

@fabpot fabpot Jan 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Copy link
Copy Markdown
Member Author

@dunglas dunglas Jan 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'll do it before the merge

Copy link
Copy Markdown
Member

@fabpot fabpot Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I let you manage this.

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Jan 21, 2016

👍

Status: Reviewed

@dunglas dunglas force-pushed the normalizer_datetime branch from f49fbc3 to 6749a70 Compare January 22, 2016 07:14
@dunglas dunglas merged commit 6749a70 into symfony:master Jan 22, 2016
dunglas added a commit that referenced this pull request Jan 22, 2016
@dunglas
feature #17411 [Serializer] Add a new DateTime normalizer (dunglas)
ed2cdfa 
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Serializer] Add a new DateTime normalizer

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | todo

This PR add support for dates and times to the Normalizer component. It supports all date and time formats supported by PHP. Dates and times are normalized in the RFC 3339 format by default. The output format can be customized using the `$context` parameter. The default format can be changed using a constructor parameter.

Usage:

```php
use Symfony\Component\Serializer\Normalizer\DateTimeNormalizer;
use Symfony\Component\Serializer\Serializer;

$serializer = new Serializer(array(new DateTimeNormalizer()));

echo $serializer->normalize(new \DateTimeImmutable('2016/01/01'));
// 2016-01-01T00:00:00+00:00

echo $serializer->normalize(new \DateTime('2016/01/01'));
// 2016-01-01T00:00:00+00:00

echo $serializer->normalize(new \DateTime('2016/01/01'), null, array(DateTimeNormalizer::FORMAT_KEY => 'Y'))
// 2016

var_dump($serializer->denormalize('2016-01-01T00:00:00+00:00', \DateTimeInterface::class));
// class DateTimeImmutable#1 (3) {
//   public $date =>
//   string(26) "2016-01-01 00:00:00.000000"
//   public $timezone_type =>
//   int(1)
//   public $timezone =>
//   string(6) "+00:00"
// }

var_dump($serializer->denormalize('2016-01-01T00:00:00+00:00', \DateTime::class));
// class DateTime#1 (3) {
//   public $date =>
//   string(26) "2016-01-01 00:00:00.000000"
//   public $timezone_type =>
//   int(1)
//   public $timezone =>
//   string(6) "+00:00"
// }
```

Commits
-------

6749a70 [Serializer] Add a new DateTime normalizer
@dunglas dunglas deleted the normalizer_datetime branch January 22, 2016 07:41
weaverryan
weaverryan reviewed Feb 21, 2016
View reviewed changes
Comment thread src/Symfony/Component/Serializer/Tests/Normalizer/DateTimeNormalizerTest.php

public function testDenormalize()
{
$this->assertEquals(new \DateTimeImmutable('2016/01/01'), $this->normalizer->denormalize('2016-01-01T00:00:00+00:00', \DateTimeInterface::class));
Copy link
Copy Markdown
Contributor

@weaverryan weaverryan Feb 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So only this one format is supported for denormalize? It feels weird - since normalize allows you to specify a different format. But I personally don't denormalize often

Copy link
Copy Markdown
Member Author

@dunglas dunglas Feb 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, denormalize can parse any format supported by \DateTime::__construct(): http://php.net/manual/en/datetime.formats.php

@dunglas dunglas mentioned this pull request Feb 23, 2016
Merged
@mcfedr mcfedr mentioned this pull request Mar 1, 2016
Closed
xabbuh added a commit to symfony/symfony-docs that referenced this pull request Mar 13, 2016
@xabbuh
feature #6314 New normalizers (mcfedr)
10ea5e9 
This PR was squashed before being merged into the master branch (closes #6314).

Discussion
----------

New normalizers

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes symfony/symfony#17603 symfony/symfony#17411 symfony/symfony#16164
| Applies to    | 3.1
| Fixed tickets |

Commits
-------

4ff3a28 New normalizers
@fabpot fabpot mentioned this pull request May 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Serializer Status: Reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.