[Process] Allow a callback whenever the output is disabled #17427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49fa263 to
c7b5705
Compare
c7b5705 to
02f0fc7
Compare
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
…bled (romainneutron) This PR was merged into the 3.1-dev branch. Discussion ---------- [Process] Allow a callback whenever the output is disabled | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | Related to #17390 | License | MIT This was not allowed in the past. However, it's possible with these changes Commits ------- 02f0fc7 [Process] Allow a callback whenever the output is disabled
fabpot
added a commit
that referenced
this pull request
Feb 28, 2016
…zsef) This PR was merged into the 3.1-dev branch. Discussion ---------- [Process] Remove unreachable return statement. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - [This return](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Process/Process.php#L1267) is [unreachable](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Process/Process.php#L1255) after #17427. Commits ------- 8f2d5bb [Process] Remove unreachable return statement.
nicolas-grekas
added a commit
that referenced
this pull request
Apr 4, 2016
…ut (nicolas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Process] Fixes & testNonBlockingNorClearingIteratorOutput | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17427 | License | MIT | Doc PR | - hasCallback (added on master in #17427) always returns true currently. Commits ------- 3a109a2 [Process] Fixes & testNonBlockingNorClearingIteratorOutput
Merged
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jun 20, 2016
…indra) This PR was merged into the 3.1 branch. Discussion ---------- Process: callbacks now allowed when output disabled This is a recent change in 3.1 added by @romainneutron Callbacks are allowed even if output is disabled Related issue: symfony/symfony#17427 Commits ------- 687b915 Process: callbacks now allowed when output disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not allowed in the past. However, it's possible with these changes