Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Serializer] Add PSR-6 adapter #17446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Serializer] Add PSR-6 adapter #17446

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
355f48c
[Serializer] Add a PSR-6 adapter
dunglas Jan 19, 2016
e368b4c
Fix error message
dunglas Jan 26, 2016
57cbfa3
Mark the trait as internal
dunglas Jan 26, 2016
c98f17a
Suggest psr/cache-implementation
dunglas Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark the trait as internal
  • Loading branch information
@dunglas
dunglas committed Jan 26, 2016
commit 57cbfa365c570f18db69661e0fe6a63648782069
2 changes: 2 additions & 0 deletions src/Symfony/Component/Serializer/Mapping/Factory/ClassResolverTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
/**
* Resolves a class name.
*
* @internal
*
* @author Kévin Dunglas <[email protected]>
*/
trait ClassResolverTrait
Copy link
Contributor

@GuilhemN GuilhemN Jan 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making this trait internal?

Copy link
Member Author

@dunglas dunglas Jan 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be useful for a userland MetadataFactory (like a Doctrine Cache one) what do you think?

Copy link
Contributor

@GuilhemN GuilhemN Jan 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case they could use the ClassUtils of doctrine/common.
IMO the behaviour of this trait is easily reproductible and should not be accessible publicly (at least in a trait which is not related directly to class management).

Expand Down