[SecurityBundle] Optimize dependency injection tests #17497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results in my machine: |
|
@javiereguiluz thanks for checking it! :) |
|
👍 |
|
Thank you @paradajozsef. |
fabpot
added a commit
that referenced
this pull request
Jan 23, 2016
…radajozsef) This PR was squashed before being merged into the 2.3 branch (closes #17497). Discussion ---------- [SecurityBundle] Optimize dependency injection tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17366 | License | MIT | Doc PR | - Tests building the same container multiple times. The same solution can be applied as here: #17399. This time I ran comparison tests only on 2.3. (my laptop is really slow) **2.3 before** ```go Time: 14.79 seconds, Memory: 48.25Mb OK (77 tests, 227 assertions) OK src/Symfony/Bundle/SecurityBundle/ ``` **2.3 after** ```go Time: 9.78 seconds, Memory: 48.75Mb OK (77 tests, 227 assertions) OK src/Symfony/Bundle/SecurityBundle/ ``` Commits ------- bf56d2f [SecurityBundle] Optimize dependency injection tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests building the same container multiple times. The same solution can be applied as here: #17399. This time I ran comparison tests only on 2.3. (my laptop is really slow)
2.3 before
2.3 after