[WebProfilerBundle] Fix design issue in profiler when having errors in forms #17561
Conversation
|
@Pierstoval thanks for providing this fix. A while ago we fixed the problem of long form types (see #17417). Could you please check if your fix is needed even after applying the mentioned merge? Thanks! |
|
I applied the fix from #17417 but even if the FQCN is reduced to the final class name, the problem persists: it does not come from the toggle buttons, but from the red error count badge. So when having long field names, the issue is still present. |
|
IMO, the right fix is not to use absolute positionning (which will make content overflow). A better way would be to use a clearfix on the parent element to ensure the floated element stays in the parent |
|
@stof your proposal is good, didn't thought about it, but now the label wraps down for long form type classes. I don't know if very long form type class names are common though 😕 |
|
@Pierstoval this is because a right-floated label should appear before the non-floated content in the DOM, not after it, if you want it to be floated near the beginning of the content rather than near the end. This is the behavior of float. |
|
I agree with @stof here. @Pierstoval could you please update this PR to use floats instead of absolute positioning? Thanks! |
|
I updated it and simply moved the error badge at the beginning of the |
|
@Pierstoval that would be a significant change. Could you please paste a screenshot of the new design? Thanks! |
|
@Pierstoval Can you provide some screenshots? Is this PR ready to be merged? |
|
Here is the new "before/after" I can test on one app with this PR:
IMO it could be merged as-is |
|
Thank you @Pierstoval. |
…ng errors in forms (Pierstoval) This PR was squashed before being merged into the 2.8 branch (closes #17561). Discussion ---------- [WebProfilerBundle] Fix design issue in profiler when having errors in forms | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This error occurs mostly when having long form field names or types, **Before:**  **After:**  That said, I don't know what to do about z-index, whether the error count prevails on the type or *vice-versa* 😕 @javiereguiluz, an idea ? Commits ------- 76e1c0a [WebProfilerBundle] Fix design issue in profiler when having errors in forms
…en having errors in forms (Pierstoval) This PR was squashed before being merged into the 2.8 branch (closes symfony#17561). Discussion ---------- [WebProfilerBundle] Fix design issue in profiler when having errors in forms | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This error occurs mostly when having long form field names or types, **Before:**  **After:**  That said, I don't know what to do about z-index, whether the error count prevails on the type or *vice-versa* 😕 @javiereguiluz, an idea ? Commits ------- 76e1c0a [WebProfilerBundle] Fix design issue in profiler when having errors in forms
This error occurs mostly when having long form field names or types,
Before:
After:
That said, I don't know what to do about z-index, whether the error count prevails on the type or vice-versa 😕
@javiereguiluz, an idea ?