[HttpKernel] Deprecate passing objects as URI attributes to the ESI and SSI renderers #17611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Jan 30, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #15056 |
| License | MIT |
| Doc PR | - |
9b18306 to
422ad9a
Compare
|
Can you update the CHANGELOG and UPGRADE files? |
| @@ -64,6 +64,10 @@ public function __construct(SurrogateInterface $surrogate = null, FragmentRender | |||
| public function render($uri, Request $request, array $options = array()) | |||
| { | |||
| if (!$this->surrogate || !$this->surrogate->hasSurrogateCapability($request)) { | |||
| if ($uri instanceof ControllerReference && $this->containsNonScalars($uri->attributes)) { | |||
| @trigger_error('Passing objects as part of URI attributes to the ESI and SSI rendering strategies is deprecated. Use another rendering strategy or use scalar values.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
you should mention that this is deprecated as of 3.1 and that this possibility will be removed in 4.0.
422ad9a to
cd2412b
Compare
|
Addressed the comments. |
|
|
||
| * 3.1.0 | ||
|
|
||
| * bug #17611 [HttpKernel] Deprecate passing objects as URI attributes to the ESI and SSI renderers |
There was a problem hiding this comment.
This file is auto-generated. I meant the CHANGELOG file for the HttpKernel Component instead. Sorry for the confusion.
|
👍 |
cd2412b to
105d3cc
Compare
105d3cc to
a38d96e
Compare
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Jan 31, 2016
…es to the ESI and SSI renderers (jakzal) This PR was merged into the 3.1-dev branch. Discussion ---------- [HttpKernel] Deprecate passing objects as URI attributes to the ESI and SSI renderers | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #15056 | License | MIT | Doc PR | - Commits ------- a38d96e [HttpKernel] Deprecate passing objects as URI attributes to the ESI and SSI renderers
|
|
||
| * Passing objects as URI attributes to the ESI and SSI renderers has been | ||
| deprecated and will be removed in Symfony 4.0. The inline fragment | ||
| renderer should be used with object attributes. |
There was a problem hiding this comment.
missing entry about the removal in the UPGRADE-4.0.md file
There was a problem hiding this comment.
It's not removed yet :)
fabpot
added a commit
that referenced
this pull request
Feb 12, 2016
…jects to ESI and SSI renderers (jakzal) This PR was merged into the 3.1-dev branch. Discussion ---------- [HttpKernel] Document the removed possibility to pass objects to ESI and SSI renderers | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Forgotten in #17611. Commits ------- 73216c9 [HttpKernel] Document the removed possibility to pass objects to ESI and SSI renderers
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.