Allow --verbose option to accept values #17647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
this is a BC break. It breaks the usage of |
|
I have not tested this patch but I"m pretty sure it won't work in all situation. The verbose option is handled in a very special way and we had to make some ugly hacks to make it work well. This probably breaks with this change. |
|
Your concerns look reasonable. Let's close this PR and let's close #10487 as "won't fix". Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The special
--verboseoption was defined as this:This is wrong, because
--verboseoption must accept integer values (--verbose=1,--verbose=2, etc.) which are equivalent to the short options (-v,-vv, etc.):In our test suite we already test values for this option:
But we didn't test them in the following way, which is now supported after this fix: