[Cache] Don't clone, serialize #17654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas it would be great to look at fixing deps=high jobs (in all affected branches). This PR looks good to me. The constructor flag allows a performance increase when storing only immutable values (scalars are immutable, references are mutable, arrays are immutable when they contain only immutable values, and objects depend on the class). |
1a7398b to
583bf40
Compare
|
@stof comment added. For the failures, I looked quickly but I'm not familiar enough with the related code. Could someone else have a look at them? |
f524aa3 to
089db2d
Compare
089db2d to
8605417
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Feb 3, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Don't clone, serialize | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Cloning is not required by PSR-6, adds overhead and doesn't prevent any mistake for nested objects. Let's simplify. ArrayCache in turn should store serialized by default, so that data is deep-cloned. But since this can cause a perf issue for some, I propose to add a constructor flag to disable serializing. WDYT? Commits ------- 8605417 [Cache] Don't clone, serialize
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning is not required by PSR-6, adds overhead and doesn't prevent any mistake for nested objects. Let's simplify.
ArrayCache in turn should store serialized by default, so that data is deep-cloned. But since this can cause a perf issue for some, I propose to add a constructor flag to disable serializing. WDYT?