add 'guid' to list of exception to filter out #17668
Conversation
| @@ -93,6 +93,13 @@ public function getEntitiesByIds($identifier, array $values) | |||
| $values = array_values(array_filter($values, function ($v) { | |||
| return (string) $v === (string) (int) $v; | |||
| })); | |||
| } elseif ('guid' === $metadata->getTypeOfField($identifier)) { | |||
| $parameterType = Connection::PARAM_INT_ARRAY; | |||
There was a problem hiding this comment.
this is wrong. You should not change this to INT_ARRAY. Uuids are not bindable as integers
There was a problem hiding this comment.
I'm open to suggestions. What should I do?
There was a problem hiding this comment.
Well, the binding type should be a string array, not an int array
|
I think this one should be closed for the same reasons #17494 was closed as well. |
|
Well, my proposal is similar to the one in #17494, but much simpler: I'd like not to fail due to a common situation. The situation is an |
|
LGTM now 👍 |
|
Thank you @garak. |
This PR was squashed before being merged into the 2.3 branch (closes #17668). Discussion ---------- add 'guid' to list of exception to filter out | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14583 | License | MIT | Doc PR | none See #14583 (comment) Commits ------- 0de86ff add 'guid' to list of exception to filter out
See #14583 (comment)