Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add 'guid' to list of exception to filter out#17668

Closed
garak wants to merge 3 commits intosymfony:2.3from
garak:patch-4
Closed

add 'guid' to list of exception to filter out#17668
garak wants to merge 3 commits intosymfony:2.3from
garak:patch-4

Conversation

@garak
Copy link
Copy Markdown
Contributor

@garak garak commented Feb 3, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #14583
License MIT
Doc PR none

See #14583 (comment)

garak added a commit to garak/symfony that referenced this pull request Feb 3, 2016
@garak
apply patch from PR 17688
313f275 
See symfony#17668
stof
stof reviewed Feb 3, 2016
View reviewed changes
Comment thread src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php Outdated
Copy link
Copy Markdown
Member

@stof stof Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. You should not change this to INT_ARRAY. Uuids are not bindable as integers

Copy link
Copy Markdown
Contributor Author

@garak garak Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to suggestions. What should I do?

Copy link
Copy Markdown
Member

@stof stof Mar 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the binding type should be a string array, not an int array

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Feb 3, 2016

seems to be related to #17488 and #17494

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Mar 2, 2016

I think this one should be closed for the same reasons #17494 was closed as well.

@garak
Copy link
Copy Markdown
Contributor Author

garak commented Mar 2, 2016

Well, my proposal is similar to the one in #17494, but much simpler: I'd like not to fail due to a common situation. The situation is an Entity type inside a form, where required option is false (or placeholder option is set). In this situation, the guid type fails on Postgres.
I don't mean to add any complex validation, like the referenced issue, just this super-simple one. I don't care about edge cases, database configuration, you name it. I'd just like to get an optional relation working.

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Mar 2, 2016

LGTM now 👍

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Mar 2, 2016

Thank you @garak.

fabpot added a commit that referenced this pull request Mar 2, 2016
@fabpot
bug #17668 add 'guid' to list of exception to filter out (garak)
59362a9 
This PR was squashed before being merged into the 2.3 branch (closes #17668).

Discussion
----------

add 'guid' to list of exception to filter out

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14583
| License       | MIT
| Doc PR        | none

See #14583 (comment)

Commits
-------

0de86ff add 'guid' to list of exception to filter out
@fabpot fabpot closed this Mar 2, 2016
@HeahDude HeahDude mentioned this pull request Mar 7, 2016
Closed
@fabpot fabpot mentioned this pull request Mar 13, 2016
Merged
This was referenced Mar 25, 2016
Merged
Closed
Merged
Merged
@garak garak deleted the patch-4 branch March 27, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Enhancement Form Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@garak @xabbuh @fabpot @stof @javiereguiluz @carsonbot