implement add and delete method #17679
Conversation
| @@ -54,6 +54,8 @@ public function __construct($host = null, $port = 389, $version = 3, $useSsl = f | |||
| $this->useSsl = (bool) $useSsl; | |||
| $this->useStartTls = (bool) $useStartTls; | |||
| $this->optReferrals = (bool) $optReferrals; | |||
|
|
|||
| $this->connect(); | |||
There was a problem hiding this comment.
I don't think it's a good idea to open the connection in the constructor.
There was a problem hiding this comment.
I don't know, the returned resource by ldap_connect() function is required by 99% of ldap_* function.
If you want, i can put as was.
There was a problem hiding this comment.
I almost think there should be a config class or an array of options passed to the constructor. That way you could have something like an auto-connect option that could default to true, but could still be changed if someone wanted to.
There was a problem hiding this comment.
@ChadSikorra PR #17560 adresses this issue of the constructor.
@L0rD59, the connection should not be done in the constructor. Indeed, services which depend on the Ldap service may actually want to do checks before even trying to connect to the Ldap server. Like checking whether the user's password is empty or not before trying to bind against the server.
|
We should keep in mind that this PR won't be compatible with the next iteration of the component. Also, this is a new feature, and thus should be implemented in the master branch instead. |
|
closing in favor of #17817 |
…azi) This PR was merged into the 3.1-dev branch. Discussion ---------- [Ldap] Add write support for the Ldap component | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17679 | License | MIT | Doc PR | no This PR implements write support for the Ldap component. Commits ------- dfd04ff Added support for adding / removing / updating Ldap entries
|
👍 |
This PR was submitted on the symfony/ldap read-only repository by @L0rD59 and automatically moved to the main repository (closes symfony/ldap#1).
Hi
Can i have some review please ?
Thx.