Adding new TargetPathTrait to get/set the authentication "target_path" #17714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Security\Http\Helper; |
There was a problem hiding this comment.
why "Helper" instead of the more common "Util" namespace?
There was a problem hiding this comment.
No reason :) I changed to Util
f70cf5b to
f957015
Compare
…" URL to the session This allows this method to be easily re-used inside custom authentication schemes.
9f786ab to
4b041dc
Compare
|
ping @symfony/deciders |
|
👍 |
| trait TargetPathTrait | ||
| { | ||
| /** | ||
| * Set the target path the user should be redirected to after authentication. |
|
👍 |
|
👍 Status: Reviewed |
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Mar 25, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Guard] fix minimum required Seucirty Http version | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17714 | License | MIT | Doc PR | Otherwise, the `TargetPathTrait` is not available. Commits ------- 952bf01 [Guard] fix minimum required Seucirty Http version
Merged
|
@weaverryan I find myself setting this path quite often manually, so this is a nice one. Will it allow us to set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This is a small guy. Basically, when you're doing custom auth (i.e. a guard authenticator), it's common to need the previous URL the user tried to get to (i.e. the "target path"). It's not much work to do it now, but it's very abstract - needing to know a weird string pattern. This just wraps that weirdness up in a simple function (
getTargetPath()).Thanks!