[Cache] Add FilesystemAdapter #17721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Feb 8, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
f47fbba to
9bfe953
Compare
9bfe953 to
9708558
Compare
| { | ||
| parent::__construct('', $defaultLifetime); | ||
|
|
||
| $dir = rtrim($directory, '/'.DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR; |
There was a problem hiding this comment.
Why do we use the DIRECTORY_SEPARATOR constant here (and below) to construct paths?
There was a problem hiding this comment.
To "file_exists" a directory, not a file
There was a problem hiding this comment.
I thought always using the forward slash works on Winwows too, doesn't it?
There was a problem hiding this comment.
It works the same yes. I tweaked the code a bit. ok for you?
|
👍 |
9708558 to
e5d6db5
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 18, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Add FilesystemAdapter | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- e5d6db5 [Cache] Add FilesystemAdapter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.