[FrameworkBundle] Improve debug:container command #17726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $io->choice('Select one of the following services to display its information', $matchingServices); | ||
| if (1 === count($matchingServices)) { | ||
| return $matchingServices[0]; | ||
| } else { |
There was a problem hiding this comment.
else can be removed as you call return in if.
There was a problem hiding this comment.
@stloyd, fixed! Thanks!
|
I don't think that it is a good idea to automatically display the information for the first service that looks similar as you won't notice that you made a mistake. |
|
@xabbuh, what about to use the default value? $default = 1 === count($matchingServices) ? 0 : null;
return $io->choice('Select one of the following services to display its information', $matchingServices, $default); |
|
@voronkovich sounds better |
|
@xabbuh, I've changed the command behavior as I proposed below. |
|
👍 |
|
Thank you @voronkovich. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2016
…onkovich) This PR was merged into the 3.1-dev branch. Discussion ---------- [FrameworkBundle] Improve debug:container command | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT | When the only one service found we could set it as a default value, so user have to just press enter to see it's definition. Commits ------- 3c6043e Improve debug:container command
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the only one service found we could set it as a default value, so user have to just press enter to see it's definition.